Copilot commented on code in PR #136:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/136#discussion_r2492364255
##########
internal/components/trigger/http.go:
##########
@@ -134,7 +135,7 @@ func (h *httpAction) request() (*http.Request, error) {
func (h *httpAction) execute() error {
req, err := h.request()
if err != nil {
- logger.Log.Errorf("failed to create new request %v", err)
+ logger.Log.Errorf("failed to create new request %v", err)
Review Comment:
Extra space between 'request' and '%v' appears to be unintentional.
```suggestion
logger.Log.Errorf("failed to create new request %v", err)
```
##########
internal/logger/log.go:
##########
@@ -32,7 +32,9 @@ func init() {
Log.Level = logrus.InfoLevel
Log.SetOutput(os.Stdout)
Log.SetFormatter(&logrus.TextFormatter{
- DisableTimestamp: true,
+ DisableTimestamp: false,
+ FullTimestamp: true,
+ TimestampFormat: "2006-01-02 15:04:05",
Review Comment:
The timestamp format is duplicated between the logger configuration and the
`formatVerificationTime()` function in `commands/verify/verify.go`. Consider
defining this format as a constant in a shared location to ensure consistency
and ease of maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
