XL-Zhao-23 opened a new pull request, #252:
URL: https://github.com/apache/skywalking-eyes/pull/252

   ### Background
   This PR fixes the compatibility issue reported in 
[apache/skywalking#13517](https://github.com/apache/skywalking/issues/13517),
   where the `make license-dep` command fails under Node.js 24 due to incorrect 
handling of platform-specific npm packages.
   
   ### Root Cause
   The SkyWalking Eyes tool failed to correctly recognize platform-specific npm 
packages
   (e.g., `@parcel/watcher-linux-x64-musl`, `@parcel/watcher-win32-arm64`), 
   resulting in license parsing errors under newer Node.js versions.
   
   ### Solution
   - Added precise **cross-platform package pattern recognition** in the npm 
resolver.
   - Implemented OS/architecture matching via regex (e.g., `-linux-x64-musl$`, 
`-win32-arm64$`).
   - Updated logic to **skip unsupported or non-current platform packages** 
before license parsing.
   
   ### Verification
   - Tested with Node.js 24.6.0 and npm 11.5.1 on Linux and macOS.
   - All licenses are now correctly identified when running `make license-dep` 
in the `banyandb` project.
   
   ### Related Issue
   Fixes apache/skywalking#13517
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to