Copilot commented on code in PR #856:
URL:
https://github.com/apache/skywalking-banyandb/pull/856#discussion_r2554919551
##########
mcp/package.json:
##########
@@ -0,0 +1,43 @@
+{
+ "name": "banyandb-mcp",
+ "version": "1.0.0",
+ "description": "MCP server for BanyanDB to support querying data by user
description",
+ "type": "module",
+ "main": "dist/index.js",
+ "scripts": {
+ "build": "tsc",
+ "start": "node dist/index.js",
+ "dev": "tsx src/index.ts",
+ "lint": "eslint src/**/*.ts",
+ "format": "prettier --write src/**/*.ts",
+ "format:check": "prettier --check src/**/*.ts"
+ },
+ "keywords": [
+ "mcp",
+ "banyandb",
+ "query",
+ "observability"
+ ],
+ "author": "Apache Software Foundation",
+ "license": "Apache-2.0",
+ "dependencies": {
+ "@modelcontextprotocol/sdk": "^1.0.0",
+ "dotenv": "^16.4.5",
+ "openai": "^4.20.0"
+ },
+ "devDependencies": {
+ "@types/node": "^20.0.0",
+ "@typescript-eslint/eslint-plugin": "^8.47.0",
+ "@typescript-eslint/parser": "^8.47.0",
+ "eslint": "^9.39.1",
+ "jsonfile": "^6.1.0",
+ "prettier": "^3.6.2",
+ "semver": "^7.6.0",
+ "tsx": "^4.7.0",
+ "typescript": "^5.3.0",
+ "typescript-eslint": "^8.47.0"
+ },
+ "engines": {
+ "node": "20.12.2"
+ }
Review Comment:
The Node.js engine version is pinned to an exact version "20.12.2" which is
overly restrictive. This will cause installation failures if users have a
different patch version of Node.js 20. Consider using a more flexible
constraint like ">=20.12.2" or "^20.12.2" to allow compatible versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
