hanahmily commented on code in PR #869:
URL:
https://github.com/apache/skywalking-banyandb/pull/869#discussion_r2570179435
##########
api/common/doc.go:
##########
@@ -15,7 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-//revive:disable:var-naming // "common" is a valid package name for shared API
types
-
// Package common defines reusable objects for APIs.
+// revive:disable:var-naming
Review Comment:
Why do you change it? The main branch's CI checks passed without issues.
##########
banyand/liaison/grpc/measure.go:
##########
@@ -228,6 +255,51 @@ func (ms *measureService) publishToNodes(ctx
context.Context, writeRequest *meas
return []string{nodeID}, nil
}
+func (ms *measureService) remapTagFamiliesForNavigate(metadata
*commonv1.Metadata,
Review Comment:
It has potential efficiency flaws:
1. It wastes CPU and memory by parsing and recreating the write request.
2. It doesn't take advantage of batch mode, as the writing logic still needs
to retrieve the subject's schema definition for each row. In typical batch
mode, this process only occurs when the specification is provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
