ButterBright commented on code in PR #873:
URL:
https://github.com/apache/skywalking-banyandb/pull/873#discussion_r2603358096
##########
banyand/measure/block.go:
##########
@@ -545,8 +548,16 @@ OUTER:
var foundTag bool
for i := range cf.columns {
if cf.columns[i].name == tagName {
- for _, v := range
cf.columns[i].values[idx:offset] {
- t.Values = append(t.Values,
mustDecodeTagValue(cf.columns[i].valueType, v))
+ schemaType, hasSchemaType :=
bc.schemaTagTypes[tagName]
+ if !hasSchemaType ||
cf.columns[i].valueType == schemaType {
Review Comment:
It has been added to schema_change_suite_test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
