wu-sheng commented on code in PR #13608:
URL: https://github.com/apache/skywalking/pull/13608#discussion_r2617115620
##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/Analyzer.java:
##########
@@ -129,6 +129,13 @@ public void analyse(final ImmutableMap<String,
SampleFamily> sampleFamilies) {
}
if (filterExpression != null) {
input = filterExpression.filter(input);
+ boolean empty = input.values().stream().allMatch(s -> s ==
SampleFamily.EMPTY);
Review Comment:
@weixiang1862 We should make sure the `job_name` filter works without an
extra payload. If the metrics list doesn't include the proper and required
metrics, we should skip the whole file, rather than skipping in each MAL
expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
