Copilot commented on code in PR #255:
URL: https://github.com/apache/skywalking-eyes/pull/255#discussion_r2635397762
##########
pkg/deps/ruby.go:
##########
@@ -222,28 +379,15 @@ func runtimeDepsFromGemspecs(dir string) ([]string,
error) {
}
runtime := make(map[string]struct{})
for _, e := range entries {
Review Comment:
Missing condition check before the continue statement. The loop will always
continue on the first iteration, never processing any gemspec files. This
appears to be a refactoring error where the condition `if e.IsDir() ||
!strings.HasSuffix(e.Name(), ".gemspec")` was accidentally removed. This will
cause the function to always return an empty list of dependencies.
```suggestion
for _, e := range entries {
if e.IsDir() || !strings.HasSuffix(e.Name(), ".gemspec") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
