Copilot commented on code in PR #13659:
URL: https://github.com/apache/skywalking/pull/13659#discussion_r2681062059
##########
oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/browser/provider/parser/errorlog/BrowserErrorLogDecorator.java:
##########
@@ -17,18 +17,28 @@
package
org.apache.skywalking.oap.server.receiver.browser.provider.parser.errorlog;
+import java.util.UUID;
import lombok.RequiredArgsConstructor;
import org.apache.skywalking.apm.network.language.agent.v3.BrowserErrorLog;
import org.apache.skywalking.apm.network.language.agent.v3.ErrorCategory;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@RequiredArgsConstructor
public class BrowserErrorLogDecorator {
private boolean isOrigin = true;
Review Comment:
The field `isOrigin` is no longer used after the refactoring but remains in
the class. This unused field should be removed to maintain code cleanliness.
##########
oap-server/server-receiver-plugin/skywalking-browser-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/browser/provider/parser/errorlog/BrowserErrorLogDecorator.java:
##########
@@ -17,18 +17,28 @@
package
org.apache.skywalking.oap.server.receiver.browser.provider.parser.errorlog;
+import java.util.UUID;
import lombok.RequiredArgsConstructor;
import org.apache.skywalking.apm.network.language.agent.v3.BrowserErrorLog;
import org.apache.skywalking.apm.network.language.agent.v3.ErrorCategory;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@RequiredArgsConstructor
public class BrowserErrorLogDecorator {
private boolean isOrigin = true;
private final BrowserErrorLog errorLog;
private BrowserErrorLog.Builder builder;
Review Comment:
The field `builder` appears to be unused after the refactoring. If it's no
longer needed for ID generation, consider removing it to reduce unnecessary
state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
