wu-sheng commented on code in PR #919:
URL:
https://github.com/apache/skywalking-banyandb/pull/919#discussion_r2686065656
##########
fodc/agent/internal/integration/metrics_export_test.go:
##########
@@ -574,6 +579,196 @@ var _ = Describe("Test Case 3: Metrics Export to
Prometheus", func() {
}
}
})
+
+ It("should capture and export KTM metrics when enabled", func() {
+ if runtime.GOOS != "linux" {
+ Skip("KTM is only supported on Linux")
+ }
Review Comment:
This and other skip logic should be able to be overridden by a parameter. By
that, we could enforce this IT running in Linux(CI pipeline). In the current
status, if any skip logic matched, we can't tell whether this test is running
or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
