hanahmily commented on code in PR #45:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/45#discussion_r2688668615
##########
chart/templates/cluster_data_statefulset.yaml:
##########
@@ -298,6 +298,90 @@ spec:
readOnly: true
{{- end }}
{{- end }}
+ {{- if and $.Values.cluster.enabled $.Values.cluster.fodc.enabled }}
+ - name: fodc-agent
+ image: {{ $.Values.cluster.fodc.agent.image.repository }}:{{ default
$.Values.image.tag $.Values.cluster.fodc.agent.image.tag }}
+ imagePullPolicy: {{ $.Values.cluster.fodc.agent.image.pullPolicy }}
+ {{- with $.Values.cluster.fodc.agent.containerSecurityContext }}
+ securityContext:
+ {{- toYaml . | nindent 12 }}
+ {{- end }}
+ command:
Review Comment:
Use "args" instead of "command" to set up flags, as the agent Docker image's
entrypoint is "/fodc-agent". The "command" is typically used to execute a
command that is not the entrypoint.
##########
chart/values.yaml:
##########
Review Comment:
values-lifecycle.yaml should be udpated as well
##########
chart/templates/cluster_fodc_proxy_deployment.yaml:
##########
@@ -0,0 +1,173 @@
+{{/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements. See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/}}
+
+{{- if and .Values.cluster.enabled .Values.cluster.fodc.enabled }}
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ template "banyandb.fullname" . }}-fodc-proxy
+ labels:
+{{ include "banyandb.labels" . | nindent 4 }}
+ app.kubernetes.io/component: fodc-proxy
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+{{ include "banyandb.selectorLabels" . | nindent 6 }}
+ app.kubernetes.io/component: fodc-proxy
+ strategy:
+ type: RollingUpdate
+ rollingUpdate:
+ maxUnavailable: 1
+ maxSurge: 1
+ template:
+ metadata:
+ labels:
+{{ include "banyandb.labels" . | nindent 8 }}
+ app.kubernetes.io/component: fodc-proxy
+{{- if .Values.cluster.fodc.proxy.podAnnotations }}
+ annotations:
+{{ toYaml .Values.cluster.fodc.proxy.podAnnotations | indent 6 }}
+{{- end }}
+ spec:
+ serviceAccountName: {{ template "banyandb.serviceAccountName" . }}
+{{- with .Values.cluster.fodc.proxy.securityContext }}
+ securityContext:
+{{ toYaml . | nindent 6 }}
+{{- end }}
+ priorityClassName: {{ .Values.cluster.fodc.proxy.priorityClassName }}
+ containers:
+ - name: fodc-proxy
+ image: {{ .Values.cluster.fodc.proxy.image.repository }}:{{ default
.Values.image.tag .Values.cluster.fodc.proxy.image.tag }}
+ imagePullPolicy: {{ .Values.cluster.fodc.proxy.image.pullPolicy }}
+{{- with .Values.cluster.fodc.proxy.containerSecurityContext }}
+ securityContext:
+{{ toYaml . | nindent 12 }}
+{{- end }}
+ env:
+{{- range $env := .Values.cluster.fodc.proxy.env }}
+ - name: {{ $env.name }}
+ value: {{ $env.value | quote }}
+{{- end }}
+ args:
+ - fodc-proxy
Review Comment:
```suggestion
```
You don't set the command defined in the entrypoint to the args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
