hanahmily commented on code in PR #937:
URL:
https://github.com/apache/skywalking-banyandb/pull/937#discussion_r2694496719
##########
banyand/measure/block.go:
##########
@@ -666,6 +666,117 @@ func (bc *blockCursor) copyTo(r *model.MeasureResult,
storedIndexValue map[commo
}
}
+func (bc *blockCursor) mergeTopNResult(r *model.MeasureResult,
storedIndexValue map[common.SeriesID]map[string]*modelv1.TagValue,
Review Comment:
Could you write a unit test to verify this function, which is crucial to the
query process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
