hanahmily commented on code in PR #943:
URL:
https://github.com/apache/skywalking-banyandb/pull/943#discussion_r2697175368
##########
pkg/query/executor/interface.go:
##########
@@ -51,6 +52,8 @@ type MIterator interface {
Current() []*measurev1.DataPoint
+ CurrentShardID() common.ShardID
+
Review Comment:
```suggestion
Current() []*measurev1.InternalDataPoint
```
##########
banyand/measure/query.go:
##########
@@ -848,6 +855,7 @@ func (qr *queryResult) merge(storedIndexValue
map[common.SeriesID]map[string]*mo
return result
}
lastSid = topBC.bm.seriesID
+ result.ShardID = topBC.shardID
Review Comment:
ShardIDs should be a slice in the result like "Timestamps"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
