ButterBright commented on code in PR #947:
URL:
https://github.com/apache/skywalking-banyandb/pull/947#discussion_r2725636954
##########
banyand/stream/tstable.go:
##########
@@ -49,21 +49,22 @@ const (
)
type tsTable struct {
- fileSystem fs.FileSystem
- pm protector.Memory
- metrics *metrics
- index *elementIndex
- snapshot *snapshot
- loopCloser *run.Closer
- getNodes func() []string
- l *logger.Logger
- introductions chan *introduction
- p common.Position
- group string
- root string
- gc garbageCleaner
- option option
- curPartID uint64
+ fileSystem fs.FileSystem
+ pm protector.Memory
+ metrics *metrics
+ index *elementIndex
+ snapshot *snapshot
+ loopCloser *run.Closer
+ getNodes func() []string
+ l *logger.Logger
+ introductions chan *introduction
+ p common.Position
+ group string
+ root string
+ gc garbageCleaner
+ option option
+ curPartID uint64
+ pendingDataCount atomic.Int64
Review Comment:
I kept it in tsTable since Gauge doesn't provide a Get method, and it will
also be exported as a metric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]