Copilot commented on code in PR #13671:
URL: https://github.com/apache/skywalking/pull/13671#discussion_r2725955304
##########
test/e2e-v2/java-test-service/pom.xml:
##########
@@ -173,4 +177,63 @@
</plugins>
</build>
-</project>
+ <profiles>
+ <profile>
+ <id>jdk-25</id>
+ <activation>
+ <jdk>[25,)</jdk>
+ </activation>
+ <properties>
+
<main.source.dir>${project.build.directory}/delombok</main.source.dir>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok-maven-plugin</artifactId>
+ <version>1.18.20.0</version>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <goals>
+ <goal>delombok</goal>
+ </goals>
+ <configuration>
+ <encoding>UTF-8</encoding>
+
<sourceDirectory>${project.basedir}/src/main/java</sourceDirectory>
+
<addOutputDirectory>false</addOutputDirectory>
+
<outputDirectory>${project.build.directory}/delombok</outputDirectory>
+ </configuration>
+ </execution>
+ </executions>
+ <dependencies>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>1.18.40</version> </dependency>
Review Comment:
There is a trailing space after the closing tag on line 213. This should be
removed to maintain consistent code formatting.
```suggestion
<version>1.18.40</version>
</dependency>
```
##########
docs/en/guides/How-to-build.md:
##########
@@ -16,7 +16,7 @@ If you need to execute build behind the proxy, edit the
*.mvn/jvm.config* and se
```
### Building from GitHub
-1. Prepare git, JDK 11, 17, 21 (LTS versions), and Maven 3.6+.
+1. Prepare git, JDK 11, 17, 21, 25 (LTS versions), and Maven 3.6+.
Review Comment:
Java 25 is not an LTS (Long-Term Support) version. Only Java 11, 17, and 21
are LTS versions. Java 25 is a non-LTS feature release. The documentation
incorrectly labels it as an LTS version. Consider either removing the "LTS
versions" label or clarifying that Java 25 is a non-LTS version that is
supported.
```suggestion
1. Prepare git, JDK 11, 17, 21 (LTS) or 25, and Maven 3.6+.
```
##########
test/e2e-v2/java-test-service/pom.xml:
##########
@@ -53,26 +53,28 @@
<guava.version>30.1.1-jre</guava.version>
<h2.version>2.1.210</h2.version>
<mysql.version>8.0.13</mysql.version>
- <lombok.version>1.18.30</lombok.version>
+ <lombok.version>1.18.36</lombok.version>
Review Comment:
Inconsistent lombok versions between main pom.xml and e2e test service. The
main pom.xml uses lombok 1.18.40, but the e2e test service pom.xml uses 1.18.36
(with 1.18.40 only in the JDK 25 profile). For consistency and to ensure all
modules properly support JDK 25, consider upgrading the base lombok version in
test/e2e-v2/java-test-service/pom.xml to 1.18.40 to match the main pom.xml.
```suggestion
<lombok.version>1.18.40</lombok.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
