hanahmily commented on code in PR #54: URL: https://github.com/apache/skywalking-banyandb-helm/pull/54#discussion_r2785730688
########## chart/values.yaml: ########## @@ -92,6 +92,39 @@ etcd-client: ## fullSyncInterval: "30m" + ## @param etcd-client.endpoints List of external etcd endpoints + ## e.g. ["etcd-0.etcd-headless.ns:2379"] + ## + endpoints: [] + + ## @section Etcd Client Authentication + ## + auth: + ## @param etcd-client.auth.username Username for etcd authentication + ## + username: "" + ## @param etcd-client.auth.password Password for etcd authentication + ## + password: "" + ## @section Etcd Client TLS Configuration + ## + tls: + ## @param etcd-client.auth.tls.enabled Enable TLS for etcd client + ## + enabled: false + ## @param etcd-client.auth.tls.secretName K8s secret name containing TLS certs + ## + secretName: "" + ## @param etcd-client.auth.tls.caFilename CA certificate filename + ## + caFilename: "ca.crt" + ## @param etcd-client.auth.tls.certFilename Client certificate filename + ## + certFilename: "tls.crt" + ## @param etcd-client.auth.tls.keyFilename Client key filename + ## + keyFilename: "tls.key" + Review Comment: ```suggestion ``` We didn't support TLS for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
