eye-gu commented on PR #976: URL: https://github.com/apache/skywalking-banyandb/pull/976#issuecomment-3940716396
> The fix looks correct, but the current test only asserts the “in-range” case (query `[150, 180]` vs block min/max `[100, 200]` → no skip). > > To better protect against regressions, consider adding tests that cover: > > 1. **Skip when query range is completely above block max** > e.g. query `[300, 400]` vs block `[100, 200]` → should skip. > 2. **Skip when query range is completely below block min** > e.g. query `[10, 50]` vs block `[100, 200]` → should skip. > 3. **Exclusive boundaries** > Cases where `IncludesLower`/`IncludesUpper` matter (e.g. query `(500, …)` vs block max `500` → should skip). > > These would validate both skip branches and boundary handling described in the issue. Thanks for the review! Added TestTagFamilyFiltersRangeBoundaryCases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
