wuwen5 commented on PR #788: URL: https://github.com/apache/skywalking-java/pull/788#issuecomment-3942183839
> I saw you added some propogation logic, but only when `isActive`. But is there a chance there is no previous context created? such as no SpringMVC ahead of this. Still nothing will be captured. I personally think we should not create a new context when isActive() is falseļ¼This component is essentially an exit instrumentation, whose responsibility is to capture and propagate an existing context rather than to create one. In the SkyWalking tracing model, the decision to start a trace should be made by upstream components (such as WebFlux, WebMVC, scheduled jobs, etc.), not by downstream exit components. This is also consistent with the execution model of Redis synchronous commands, where exit spans are not forcibly correlated with each other when there is no active upstream context, and each span remains independent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
