Hyeon-moGu commented on PR #13713: URL: https://github.com/apache/skywalking/pull/13713#issuecomment-3960946023
> Meter system would be changed to remove static, they have caches and critical as kernel. No point to risk for testing. Thank you for your valuable feedback., @wu-sheng. I have updated the PR to address your concerns: - Restored the final keyword in MetricsStreamProcessor.java to keep the kernel stable. - Used MockedStatic in MeterSystemTest to inject the mock without modifying the production code. - Verified that all tests pass in the server-library, server-core, and server-configuration modules locally. I really appreciate your guidance on this. Please take another look when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
