wu-sheng commented on code in PR #13723: URL: https://github.com/apache/skywalking/pull/13723#discussion_r2883886682
########## oap-server/analyzer/log-analyzer/src/main/java/org/apache/skywalking/oap/log/analyzer/v2/provider/LALConfigs.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.log.analyzer.v2.provider; + +import java.io.File; +import java.io.FileNotFoundException; +import java.io.FileReader; +import java.io.IOException; +import java.io.Reader; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; +import lombok.Data; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.oap.server.library.module.ModuleStartException; +import org.apache.skywalking.oap.server.library.util.ResourceUtils; +import org.yaml.snakeyaml.Yaml; + +import static com.google.common.base.Preconditions.checkArgument; +import static com.google.common.io.Files.getNameWithoutExtension; +import static org.apache.skywalking.oap.server.library.util.StringUtil.isNotBlank; +import static org.apache.skywalking.oap.server.library.util.CollectionUtils.isEmpty; + +@Data +@Slf4j +public class LALConfigs { + private List<LALConfig> rules; + + public static List<LALConfigs> load(final String path, final List<String> files) throws Exception { + if (isEmpty(files)) { + return Collections.emptyList(); + } + + checkArgument(isNotBlank(path), "path cannot be blank"); + + try { + final File[] rules = ResourceUtils.getPathFiles(path); + + return Arrays.stream(rules) + .filter(File::isFile) + .filter(it -> { + //noinspection UnstableApiUsage + return files.contains(getNameWithoutExtension(it.getName())); + }) + .map(f -> { + try (final Reader r = new FileReader(f)) { + return new Yaml().<LALConfigs>loadAs(r, LALConfigs.class); + } catch (IOException e) { + log.debug("Failed to read file {}", f, e); + } + return null; Review Comment: This matches v1 behavior. The actual fail-fast happens later during LAL compilation — if a rule is needed but its config was unparseable, the compiler will throw at startup. The graceful loading here allows partial config sets to work (e.g., when a config directory contains non-LAL files). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
