hanahmily commented on code in PR #992:
URL:
https://github.com/apache/skywalking-banyandb/pull/992#discussion_r2899219630
##########
banyand/measure/snapshot.go:
##########
@@ -370,16 +377,25 @@ func (s *snapshotListener) Rev(ctx context.Context,
message bus.Message) bus.Mes
}
groupName := g.GetSchema().Metadata.Name
snapshotPath := filepath.Join(s.s.snapshotDir, sn, groupName)
- if errGroup := s.s.takeGroupSnapshot(snapshotPath, groupName);
errGroup != nil {
+ created, errGroup := s.s.takeGroupSnapshot(snapshotPath,
groupName)
+ if errGroup != nil {
s.s.l.Error().Err(errGroup).Str("group",
groupName).Msg("fail to take group snapshot")
err = multierr.Append(err, errGroup)
continue
}
+ if !created {
+ s.s.l.Debug().Str("group", groupName).Msg("skip empty
group snapshot")
Review Comment:
```suggestion
s.s.l.Info().Str("group", groupName).Msg("skip empty
group snapshot")
```
##########
CHANGES.md:
##########
@@ -25,6 +25,7 @@ Release Notes.
- Add a generic snapshot coordination package for atomic snapshot transitions
across trace and sidx.
- Support map-reduce aggregation for measure queries: map phase (partial
aggregation on data nodes) and reduce phase (final aggregation on liaison).
- Add eBPF-based KTM I/O monitor for FODC agent.
+- Ignore take snapshot when no data.
Review Comment:
Move this line to a bug section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
