hanahmily commented on code in PR #995:
URL:
https://github.com/apache/skywalking-banyandb/pull/995#discussion_r2905200697
##########
api/proto/banyandb/schema/v1/internal.proto:
##########
@@ -85,4 +85,19 @@ message AggregateSchemaUpdatesResponse {
service SchemaUpdateService {
rpc AggregateSchemaUpdates(AggregateSchemaUpdatesRequest) returns
(AggregateSchemaUpdatesResponse);
+ rpc WatchSchemas(WatchSchemasRequest) returns (stream WatchSchemasResponse);
Review Comment:
I think keeping WatchSchemas as server-streaming (rpc
WatchSchemas(WatchSchemasRequest) returns (stream WatchSchemasResponse)) is the
better fit for a “watch” API here.
##########
api/proto/banyandb/schema/v1/internal.proto:
##########
@@ -85,4 +85,19 @@ message AggregateSchemaUpdatesResponse {
service SchemaUpdateService {
rpc AggregateSchemaUpdates(AggregateSchemaUpdatesRequest) returns
(AggregateSchemaUpdatesResponse);
+ rpc WatchSchemas(WatchSchemasRequest) returns (stream WatchSchemasResponse);
Review Comment:
Can the synchronization process also utilize the streaming service? If so,
the AggregateSchemaUpdates can be eliminated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
