liuhaolong10 commented on PR #796:
URL: https://github.com/apache/skywalking-java/pull/796#issuecomment-4036106091
1. When adding the new plugin, my intention was to verify and cover as many
versions as possible, so I validated the `spring-boot-starter-amqp` versions
from 2.0.0.RELEASE to 2.4.0. Although these versions are no longer maintained
by Spring, they are still widely used in many companies' projects. I verified
these versions to clearly indicate which versions the new plugin supports. If
the test scenarios involving EOL (End of Life) versions introduce security
risks, I can remove the corresponding test scenario code.
2. You are absolutely right that the thread name check mechanism is
problematic — this was an oversight on my part. After sorting out the code
logic, I plan to modify it to judge by object type instead:
```java
Consumer consumer = (Consumer) allArguments[6];
if (consumer != null &&
"org.springframework.amqp.rabbit.listener.BlockingQueueConsumer$InternalConsumer".equals(consumer.getClass().getName()))
{
return;
}
3. I will refactor the plugin code to use the plugin v2 APIs in my next
commit.
4. I will update the Supported-list.d file in my next commit as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
