hanahmily commented on code in PR #1001: URL: https://github.com/apache/skywalking-banyandb/pull/1001#discussion_r2918724400
########## banyand/measure/topn.go: ########## Review Comment: 1. Utilize Go's generic types to implement topNStreamingProcessor, TopNValue, and related components. It is preferable to minimize the "switch" logic in this context. 2. Convert []float to []int using encoding.Float64ListToDecimalIntList. Subsequently, marshal the int64 list following the existing logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
