mrproliu commented on code in PR #1007:
URL:
https://github.com/apache/skywalking-banyandb/pull/1007#discussion_r2922880155
##########
pkg/test/setup/setup.go:
##########
@@ -609,13 +609,23 @@ func CMD(flags ...string) func() {
}
}
+func hasFlag(flags []string, target string) bool {
+ for _, f := range flags {
+ if f == target {
+ return true
+ }
+ }
+ return false
+}
+
func startDataNode(config *ClusterConfig, dataDir string, flags ...string)
(string, string, func()) {
if config == nil {
config = defaultClusterConfig
}
isPropertyMode := config.SchemaRegistry.Mode == ModeProperty
+ runSchemaServer := isPropertyMode && !hasFlag(flags,
"--has-schema-role=false")
portCount := 2
- if isPropertyMode {
+ if runSchemaServer {
portCount = 3
Review Comment:
Update the flag verify logical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
