hanahmily commented on code in PR #57:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/57#discussion_r2930952241
##########
chart/templates/_helpers.tpl:
##########
@@ -147,6 +147,8 @@ Includes: repair cron, schema server parameters, schema
server TLS
{{- define "banyandb.schemaStoragePropertyServerEnv" -}}
{{- $schemaMode := (default dict .Values.cluster.schemaStorage).mode | default
"property" }}
{{- if eq $schemaMode "property" }}
+- name: BYDB_HAS_META_ROLE
Review Comment:
Can I set it to always be true? True is the default value, meaning we do not
need to set it.
##########
chart/templates/cluster_data_statefulset.yaml:
##########
@@ -175,7 +175,15 @@ spec:
{{- end }}
{{- end }}
{{- include "banyandb.schemaStorageEnv" $ | nindent 12 }}
+ {{- if eq $roleName "hot" }}
Review Comment:
You do not use "hot" in the template. "hot" is a variable that can be set to
any value.
Instead, add the "hasMetaRole" to "cluster.data.nodeTemplate" and set
"roles.hot.hasMetaRole:true"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
