Copilot commented on code in PR #1045:
URL:
https://github.com/apache/skywalking-banyandb/pull/1045#discussion_r3031832481
##########
ui/src/components/Property/PropertyRead.vue:
##########
@@ -40,13 +40,30 @@
tableData: [],
name: route.params.name,
});
- const yamlCode = ref(`name: ${data.name}
-limit: 10`);
+ const yamlCode = ref(buildSearchYaml(data.name, 10));
const showTracesDialog = ref(false);
const traceData = ref(null);
- const getProperties = async (params) => {
+
+ function buildSearchYaml(name, limit) {
+ return `name: ${name}
+limit: ${limit}`;
Review Comment:
`buildSearchYaml` returns a multiline template literal where the second line
is indented in the source, which means the generated YAML includes leading
whitespace before `limit:`. This makes the default editor content harder to
read and can change YAML interpretation/validation depending on the parser.
Consider constructing the string without indentation (e.g., explicit `\n` join
or trimming leading whitespace) so both keys start at the same column.
```suggestion
return [`name: ${name}`, `limit: ${limit}`].join('\n');
```
##########
CHANGES.md:
##########
@@ -19,6 +19,7 @@ Release Notes.
- MCP: Add validation for properties and harden the mcp server.
- Fix property schema client connection not stable after data node restarted.
- Fix flaky on-disk integration tests caused by Ginkgo v2 random container
shuffling closing gRPC connections prematurely.
+- ui: fix query editor refresh/reset behavior and BydbQL keyword highlighting
Review Comment:
CHANGES entries in this section consistently end with a period; this new
bullet is missing trailing punctuation. Please add a period for consistency
with the surrounding release notes formatting.
```suggestion
- ui: fix query editor refresh/reset behavior and BydbQL keyword
highlighting.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
