currenjin opened a new pull request, #13798:
URL: https://github.com/apache/skywalking/pull/13798

   ### Add unit tests for JDBCTopologyQueryDAO SQL building
   
   Add tests to verify the SQL query construction in `JDBCTopologyQueryDAO`, 
covering:
   - `loadServiceRelationsDetectedAtServerSide` with no serviceIds: no extra 
filter appended
   - `loadServiceRelationsDetectedAtServerSide` with single serviceId: `and 
(source=? or dest=?)` properly parenthesized
   - `loadServiceRelationsDetectedAtServerSide` with multiple serviceIds: OR 
conditions chained correctly with proper parentheses
   - `loadInstanceRelationDetectedAtServerSide`: bidirectional condition 
`((source=A and dest=B) or (source=B and dest=A))` is correctly formed
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace 
the issue number. Closes #<issue number>.
   - [ ] Update the [`CHANGES` 
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to