wl2027 commented on code in PR #240: URL: https://github.com/apache/skywalking-go/pull/240#discussion_r3045091273
########## docs/en/agent/support-plugins.md: ########## @@ -21,11 +21,13 @@ metrics based on the tracing data. * `microv4`: [Go-Micro](https://github.com/go-micro/go-micro) tested v4.6.0 to v4.10.2. * `grpc` : [gRPC](https://github.com/grpc/grpc-go) tested v1.55.0 to v1.64.0. * Database Client - * `gorm`: [GORM](https://github.com/go-gorm/gorm) tested v1.22.0 to v1.25.1. + * `gorm`: [GORM](https://github.com/go-gorm/gorm) tested v1.22.0 to v1.25.10. Review Comment: I reverted `gorm` back to `v1.25.1` for now. When I tried to extend the GORM test coverage to `v1.25.10`, I found that upstream GORM changed how `LIMIT/OFFSET` is generated. For example, in GORM tests `LIMIT 1` becomes a parameterized `LIMIT ?` with `1` moved into the bound parameters. go-gorm/gorm#6806 The current plugin scenario `excepted.yml` does not seem to support covering these different but valid outputs in a single file. Should we enhance the `excepted.yml` matcher in a follow-up to handle this kind of case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
