Copilot commented on code in PR #1109:
URL:
https://github.com/apache/skywalking-banyandb/pull/1109#discussion_r3172662909
##########
banyand/queue/queue.go:
##########
@@ -32,6 +33,13 @@ import (
"github.com/apache/skywalking-banyandb/pkg/run"
)
+// ErrNotImplemented is returned by Client implementations that have no peers
+// to dial — notably the standalone local pipeline. Callers (e.g. the cluster
+// barrier fan-out) treat this sentinel as "no peer to probe; skip" rather
+// than as a hard failure, so the standalone path degrades to in-process
+// self-probing without a special-cased branch in the caller.
+var ErrNotImplemented = errors.New("not implemented")
Review Comment:
ErrNotImplemented’s error text is very generic ("not implemented"), which
can make logs/metrics hard to interpret when this sentinel escapes the queue
package. Consider making the message more specific (e.g., include the
package/operation) while keeping it a sentinel var for errors.Is comparisons.
```suggestion
var ErrNotImplemented = errors.New("queue client operation not implemented")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
