hanahmily commented on code in PR #1105:
URL:
https://github.com/apache/skywalking-banyandb/pull/1105#discussion_r3177742916
##########
bydbctl/internal/cmd/root.go:
##########
@@ -123,7 +123,7 @@ func initConfig() {
return fmt.Errorf("unable to stat config file: %w", err)
}
if info.Mode().Perm() != 0o600 {
- fmt.Printf("config file %s has unsafe permissions: %o
(expected 0600)", configFile, info.Mode().Perm())
+ fmt.Fprintf(os.Stderr, "config file %s has unsafe
permissions: %o (expected 0600)\n", configFile, info.Mode().Perm())
}
// Dump this to stderr in case of mixing up response yaml
fmt.Fprintln(os.Stderr, "Using config file:", configFile)
Review Comment:
@paultanay Route them through rootCmd.ErrOrStderr() instead of os.Stderr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
