hanahmily opened a new pull request, #1114: URL: https://github.com/apache/skywalking-banyandb/pull/1114
## Summary - Drop `block_writer`'s per-traceID timestamp monotonicity panic in `banyand/trace`. Spans of one SkyWalking trace originate from multiple Java agents whose wall clocks drift relative to each other; trace storage is keyed by traceID rather than timestamp, so the invariant the writer was asserting does not hold for legitimate input. - Remove the now-unused `minTimestampLast` field and reset. - Add a regression test (`TestBlockWriter_OutOfOrderTimestampsSameTraceID`) that mirrors the exact traceID/timestamp samples from the issue. Fixes apache/skywalking#13860 — production OAP 10.4.0 traffic was tripping the panic about once per minute, silently shedding one trace-write batch each time. ## Test plan - [x] `make license-check && make check-req && make build && make lint && make check` - [x] `make test-ci PKG=./banyand/...` - [x] `make test-ci PKG=./bydbctl/...` - [x] `make test-ci PKG=./pkg/...` - [x] `make test-ci PKG=./fodc/...` - [x] `make test-ci PKG=./test/integration/standalone/...` - [x] `make test-ci PKG=./test/integration/distributed/...` - [ ] e2e (requires Kubernetes — skipped locally) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
