mrproliu commented on code in PR #1115:
URL:
https://github.com/apache/skywalking-banyandb/pull/1115#discussion_r3198633407
##########
banyand/internal/storage/index.go:
##########
@@ -384,6 +420,9 @@ func (s *seriesIndex) SearchWithoutSeries(ctx
context.Context, opts IndexSearchO
}
func (s *seriesIndex) Close() error {
+ if s == nil {
+ return nil
+ }
s.metrics.DeleteAll(s.p.SegLabelValues()...)
Review Comment:
Add comment about this
##########
banyand/queue/sub/group_lifecycle.go:
##########
@@ -77,12 +82,14 @@ func (s *server) inspectGroup(ctx context.Context, group
*commonv1.Group) *fodcv
Catalog: catalogToString(group.Catalog),
ResourceOpts: group.ResourceOpts,
}
- dataInfo, err := s.metadataRepo.CollectDataInfo(ctx, groupName)
+ dataInfo, collectionErrs, err := s.metadataRepo.CollectDataInfo(ctx,
groupName)
+ info.Errors = collectionErrs
if err != nil {
s.log.Warn().Err(err).Str("group", groupName).Msg("Failed to
collect data info")
- } else {
- info.DataInfo = dataInfo
+ info.Errors = append([]string{topLevelErrorPrefix +
err.Error()}, info.Errors...)
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
