This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch v0.10.x
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git

commit 1f8e29f37c96fa81cb5e1fd0344bfc0a2750525f
Author: Hongtao Gao <[email protected]>
AuthorDate: Fri May 8 06:28:44 2026 +0000

    chore: fix lint issues after cherry-pick
    
    via [HAPI](https://hapi.run)
    
    Co-Authored-By: HAPI <[email protected]>
---
 banyand/trace/metadata_test.go | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/banyand/trace/metadata_test.go b/banyand/trace/metadata_test.go
index 13c74a30e..58994f525 100644
--- a/banyand/trace/metadata_test.go
+++ b/banyand/trace/metadata_test.go
@@ -270,7 +270,7 @@ var _ = Describe("Metadata", func() {
 
                                Eventually(func(innerGm Gomega) {
                                        spans := 
querySchemaChangeTraceData(svcs, traceName, groupName, now.Add(-3*time.Hour), 
now,
-                                               []string{"trace_id", 
"service_id", "duration"}, nil)
+                                               []string{"trace_id", 
"service_id", "duration"})
                                        innerGm.Expect(spans).To(HaveLen(8))
 
                                        for _, span := range spans {
@@ -297,7 +297,7 @@ var _ = Describe("Metadata", func() {
 
                                Eventually(func(innerGm Gomega) {
                                        spans := 
querySchemaChangeTraceData(svcs, traceName, groupName, now.Add(-3*time.Hour), 
now,
-                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"}, nil)
+                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"})
                                        innerGm.Expect(spans).To(HaveLen(8))
 
                                        oldDataCount := 0
@@ -333,7 +333,7 @@ var _ = Describe("Metadata", func() {
 
                                Eventually(func(innerGm Gomega) {
                                        spans := 
querySchemaChangeTraceData(svcs, traceName, groupName, now.Add(-3*time.Hour), 
now,
-                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"}, nil)
+                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"})
                                        innerGm.Expect(spans).To(HaveLen(8))
 
                                        nullCount := 0
@@ -383,7 +383,7 @@ var _ = Describe("Metadata", func() {
                                Eventually(func(innerGm Gomega) {
                                        spans := 
querySchemaChangeTraceData(svcs, traceName, groupName,
                                                now.Add(-3*time.Hour), now,
-                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"}, nil)
+                                               []string{"trace_id", 
"service_id", "duration", "extra_tag"})
                                        innerGm.Expect(spans).To(HaveLen(8))
 
                                        nullCount := 0
@@ -704,7 +704,7 @@ func writeSchemaChangeTraceData(svcs *services, name, group 
string, baseTime tim
        }
 }
 
-func querySchemaChangeTraceData(svcs *services, name, group string, begin, end 
time.Time, tags []string, criteria *modelv1.Criteria) []*tracev1.Span {
+func querySchemaChangeTraceData(svcs *services, name, group string, begin, end 
time.Time, tags []string) []*tracev1.Span {
        req := &tracev1.QueryRequest{
                Groups: []string{group},
                Name:   name,
@@ -718,9 +718,6 @@ func querySchemaChangeTraceData(svcs *services, name, group 
string, begin, end t
                        Sort:          modelv1.Sort_SORT_DESC,
                },
        }
-       if criteria != nil {
-               req.Criteria = criteria
-       }
        var spans []*tracev1.Span
        Eventually(func() bool {
                feat, err := svcs.pipeline.Publish(context.Background(), 
data.TopicTraceQuery, bus.NewMessage(bus.MessageID(time.Now().UnixNano()), req))
@@ -774,4 +771,3 @@ func getFilePartCount(svcs *services, group string) int64 {
        }
        return total
 }
-

Reply via email to