Copilot commented on code in PR #196: URL: https://github.com/apache/skywalking-swck/pull/196#discussion_r3217172934
########## adapter/go.mod: ########## @@ -1,6 +1,6 @@ module github.com/apache/skywalking-swck/adapter -go 1.25.10 +go 1.26.3 Review Comment: The `go` directive here uses a patch version (`1.26.3`), while the other module in this repo pins the minor line with a `.0` patch (`operator/go.mod` uses `go 1.26.0`). Consider aligning the adapter to `go 1.26.0` (or `go 1.26`) and rely on the Docker base image / CI toolchain selection to pin the exact patch level, to avoid confusion or potential tooling incompatibilities around non-`.0` patch versions in the `go` directive. ########## adapter/Dockerfile: ########## @@ -14,7 +14,7 @@ # limitations under the License. # Build the manager binary -FROM golang:1.26 As builder +FROM golang:1.26.3 As builder Review Comment: Dockerfile stages are written with `AS` elsewhere in this repo (e.g., `operator/Dockerfile` and `build/images/Dockerfile.release`). For consistency, consider changing `As builder` to `AS builder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
