hanahmily opened a new pull request, #1131:
URL: https://github.com/apache/skywalking-banyandb/pull/1131
## Summary
The hourly **Flaky Test** cron has been failing on every run since #1121
(CP-6 schema-barrier load harness) landed. The failure is not actually flaky —
it's a deterministic Ginkgo setup error:
```
# github.com/apache/skywalking-banyandb/test/load/schema_barrier
package github.com/apache/skywalking-banyandb/test/load/schema_barrier:
build constraints exclude all Go files
FAIL github.com/apache/skywalking-banyandb/test/load/schema_barrier
[setup failed]
##[error]Process completed with exit code 2.
```
Root cause: `test/load/schema_barrier/` contains only one file,
`barrier_loadtest_test.go`, gated by `//go:build loadtest`. The flaky-test
workflow runs `make test-ci PKG=./...`, so Ginkgo recurses into the directory
and tries to compile the package without the tag — there are zero matching Go
files, so the suite aborts.
This PR narrows the flaky cron's `PKG` to the Go roots that exclude
`./test/load/...`. The harness remains runnable via `make load-test-barrier`;
any future tag-gated load package added under `./test/load/...` will also be
ignored by the cron with no further change.
- `.github/workflows/flaky-test.yml`: enumerate the per-root PKG list,
excluding `./test/load/...`, with a comment explaining why.
- `.github/workflows/test.yml`: quote `"PKG=${{ inputs.pkg }}"` so a
whitespace-separated multi-path input survives `make`'s argv parsing.
Backward-compatible: the default `./...` (no whitespace) behaves identically;
without the quoting, `make test-ci PKG=./a/... ./b/...` would bind only the
first path and fail with `No rule to make target 'b/...'`.
Verified locally:
- `go list ./api/... ./banyand/... ... ./test/property_repair/...` resolves
to 220 packages, zero under `./test/load/`.
- `make ... 'PKG=./a/... ./b/...'` → `PKG=./a/... ./b/...`; unquoted form
errors as above.
## Test plan
- [ ] Next scheduled run of `Flaky Test` (cron `50 * * * *`) on `main`
completes without the schema_barrier compile failure.
- [ ] Regular PR CI (`Test`, etc.) using `test.yml` with the default `pkg:
./...` continues to pass unchanged.
🤖 Generated with [Claude Code](https://claude.com/claude-code) via
[HAPI](https://hapi.run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
