hanahmily commented on PR #1133: URL: https://github.com/apache/skywalking-banyandb/pull/1133#issuecomment-4465182051
The v2 report contract must ensure one invariant: **`completion_rate == 100%` means "the migration finished successfully" for every resource type — parts, series, and element_index alike. Nothing less, and never more.** Option 1 and option 2 both leave the primary `completion_rate` able to read 266 % or 5 %, which violates the invariant regardless of documentation or sibling fields. Option 3 is the path that satisfies it. Reshape the visitor so `Counts` reflects source-cardinality and the numerator counts source items whose entire fan-out succeeded. Per-target tracking for resume granularity can stay internal — the report only needs to expose source-level numbers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
