wu-sheng opened a new pull request, #156:
URL: https://github.com/apache/skywalking-query-protocol/pull/156

   ## Summary
   
   Reverts #155 in preparation for a more comprehensive alarm query API that 
bundles the layer field together with entity-id / rule-name filters under a 
single new `queryAlarms(condition: AlarmQueryCondition!)` query.
   
   #155 added a `layers` argument to the existing `getAlarm` and a `layers: 
[String!]!` field to `AlarmMessage`. The new PR will instead:
   
   - Keep `getAlarm` at its pre-#155 signature (back-compat for current 
clients).
   - Introduce a new `queryAlarms` query with a single `AlarmQueryCondition` 
input type carrying `layers`, `serviceIds`, `serviceInstanceIds`, 
`endpointIds`, `ruleNames`, `scope`, `keyword`, `tags`, `duration`, and 
`paging`.
   - Re-introduce `AlarmMessage.layers: [String!]!` in that new PR alongside 
the `queryAlarms` schema, so the layer story ships in a single coherent change 
instead of accreting argument-by-argument on `getAlarm`.
   
   The follow-up PR will land before the OAP backend implementation, so this 
revert leaves the schema clean for the new shape.
   
   ## Test plan
   
   - [ ] Confirm `getAlarm` signature returns to its pre-#155 form
   - [ ] Confirm `AlarmMessage` no longer has the `layers` field (it returns in 
the new PR)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to