Copilot commented on code in PR #254:
URL:
https://github.com/apache/skywalking-satellite/pull/254#discussion_r3256752852
##########
docker/Dockerfile:
##########
@@ -30,9 +30,11 @@ RUN mv
/src/bin/skywalking-satellite-${VERSION}-linux-${TARGETARCH} /src/bin/sky
FROM alpine:3.23
-RUN apk update --no-cache && \
+RUN echo '@edge https://dl-cdn.alpinelinux.org/alpine/edge/main' >>
/etc/apk/repositories && \
+ apk update --no-cache && \
apk upgrade --no-cache && \
Review Comment:
Adding the edge repository and then running `apk upgrade` can
unintentionally upgrade additional base packages (potentially from edge
depending on pinning/selection), making the image less reproducible and
increasing the risk of ABI/runtime breakage. Prefer avoiding a full `apk
upgrade` here and instead upgrade only the specific packages being targeted
(e.g., via `apk add --upgrade ...` / explicit version constraints) so the
change scope stays minimal.
##########
docker/Dockerfile:
##########
@@ -30,9 +30,11 @@ RUN mv
/src/bin/skywalking-satellite-${VERSION}-linux-${TARGETARCH} /src/bin/sky
FROM alpine:3.23
-RUN apk update --no-cache && \
+RUN echo '@edge https://dl-cdn.alpinelinux.org/alpine/edge/main' >>
/etc/apk/repositories && \
+ apk update --no-cache && \
Review Comment:
This permanently appends the edge repository to `/etc/apk/repositories` in
the final runtime image. To reduce the chance of accidentally pulling edge
packages in later layers/derived images (and to keep the runtime image closer
to Alpine 3.23 stable), consider using `apk add --repository <edge-url> ...`
for just the needed packages or removing the edge repo entry after installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
