wu-sheng opened a new pull request, #160:
URL: https://github.com/apache/skywalking-query-protocol/pull/160
## Summary
Two doc / cleanup items spotted during apache/skywalking#13877 review:
* **AlarmQueryCondition.entities**: schema text said relation entities
match whether the entity appears as source or dest, but the OAP DAO
has always implemented an exact-ordered match
(\`id0 = sourceId AND id1 = destId\`). Rewrite the entity comment to
match the implemented semantics and point operators at the
non-relation widening pattern. Non-relation matching (\`id0 OR id1\`)
is unchanged and now documented explicitly.
* **ui-configuration.graphqls**: \`DashboardConfiguration\` /
\`MenuItem\` / template + menu Query/Mutation types are no longer
loaded by \`GraphQLQueryProvider\` (apache/skywalking 11.0.0 moves UI
template management to a REST surface on the admin host; menu
management is removed entirely in favor of Horizon UI client-side
gating). The file was left in the submodule but is unreachable from
any resolver. Delete it.
## Test plan
- [ ] OAP boot: GraphQL schema validates with the file gone — no resolver
references it (confirmed via grep across apache/skywalking).
- [ ] Schema doc-only change for the entity filter — no resolver behavior
changes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
