wu-sheng opened a new pull request, #161:
URL: https://github.com/apache/skywalking-query-protocol/pull/161
## Summary
Two doc / cleanup items spotted during apache/skywalking#13877 review:
* **alarm.graphqls** — \`AlarmQueryCondition.entities\` text said
relation entities match whether the entity appears as source or
dest, but the OAP DAO has always implemented exact-ordered match
(\`id0 = sourceId AND id1 = destId\`). Rewrite the entity comment
to match the implemented semantics and point operators at the
non-relation widening pattern. Non-relation matching
(\`id0 OR id1\`) is unchanged and now documented explicitly.
* **ui-configuration.graphqls** — drop the menu surface
(\`MenuItem\` type + \`getMenuItems\` query). Sidebar menu
management is removed from OAP in apache/skywalking 11.0.0 in
favor of Horizon UI client-side gating. **All template CRUD stays
intact**: \`DashboardConfiguration\`, \`NewDashboardSetting\`,
\`DashboardSetting\`, \`TemplateChangeStatus\`, \`getTemplate\`,
\`getAllTemplates\`, \`addTemplate\`, \`changeTemplate\`,
\`disableTemplate\` — operators still need them.
Supersedes #160 (which over-deleted the whole ui-configuration file).
## Test plan
- [ ] OAP boot: GraphQL schema validates without \`MenuItem\` /
\`getMenuItems\`; the apache/skywalking-side resolver no longer
references the menu service.
- [ ] Template CRUD still callable via GraphIQL.
- [ ] Doc-only change for alarm entity filter — no resolver behavior
changes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
