This is an automated email from the ASF dual-hosted git repository.
wu-sheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-horizon-ui.git
The following commit(s) were added to refs/heads/main by this push:
new 098ccf9 chore: scrub stale 'Phase X' comments — all referenced
surfaces shipped
098ccf9 is described below
commit 098ccf96dd3a3b892929f6a01613b49f33ea1891
Author: Wu Sheng <[email protected]>
AuthorDate: Tue May 19 20:52:09 2026 +0800
chore: scrub stale 'Phase X' comments — all referenced surfaces shipped
Every remaining 'Phase X' note described work that's now done:
- apps/bff/src/logic/inspect/exec.ts: 'MqeTargetCache (Phase 3)' →
drop the parenthetical; the cache exists. Also drop the SWIP-14
prefix on the same sentence — the rationale stands without naming
the upstream spec by number.
- apps/bff/src/http/admin/inspect.ts: 'inspect-exec.ts (Phase 4)' +
'/api/inspect/catalog (Phase 2)' — both endpoints are live; drop
the phase tags.
- packages/api-client/src/dashboard.ts: 'Phase 7 admin lets operators
edit + persist their own widget set' → rewritten to describe the
shipped flow (Dashboard setup admin pages → /api/admin/templates/
save → OAP).
- docs/operate/cluster-metadata.md: 'A planned strip for upcoming
metadata views' bullet + the 'Coming soon (Phase 6 / 7)' ASCII
mockup block — both removed. The ClusterStatusView itself already
had the visible strip deleted in an earlier commit; this brings
the docs into alignment.
No 'Phase X' references in code or docs after this commit.
---
apps/bff/src/http/admin/inspect.ts | 5 ++---
apps/bff/src/logic/inspect/exec.ts | 6 +++---
docs/operate/cluster-metadata.md | 8 --------
packages/api-client/src/dashboard.ts | 4 +++-
4 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/apps/bff/src/http/admin/inspect.ts
b/apps/bff/src/http/admin/inspect.ts
index 21827bb..1b4cea5 100644
--- a/apps/bff/src/http/admin/inspect.ts
+++ b/apps/bff/src/http/admin/inspect.ts
@@ -24,9 +24,8 @@
*
* The MQE values themselves are NOT served here — those go via the
* regular GraphQL `execExpression` mutation, which the BFF proxies in
- * `inspect-exec.ts` (Phase 4). The merged catalog endpoint
- * `/api/inspect/catalog` (Phase 2) layers Studio-side rule attribution
- * on top of `/inspect/metrics`.
+ * `inspect-exec.ts`. The merged catalog endpoint `/api/inspect/catalog`
+ * layers Studio-side rule attribution on top of `/inspect/metrics`.
*
* Inspect is read-only and metadata-ish — every route is gated on a
* single `inspect:read` verb. There is no write surface.
diff --git a/apps/bff/src/logic/inspect/exec.ts
b/apps/bff/src/logic/inspect/exec.ts
index 66b5eab..8192a98 100644
--- a/apps/bff/src/logic/inspect/exec.ts
+++ b/apps/bff/src/logic/inspect/exec.ts
@@ -20,9 +20,9 @@
* `mutation execExpression(expression, entity, duration)` and returns
* the `ExpressionResult` payload to the SPA.
*
- * SWIP-14 deliberately punts value queries off the admin port so that
- * MQE auth / quotas / observability stay on a single surface. The BFF
- * resolves that surface via `MqeTargetCache` (Phase 3) and is the
+ * The Inspect API deliberately punts value queries off the admin port
+ * so that MQE auth / quotas / observability stay on a single surface.
+ * The BFF resolves that surface via `MqeTargetCache` and is the
* single egress point for MQE traffic from Studio.
*
* The handler validates inbound shape, builds the GraphQL request,
diff --git a/docs/operate/cluster-metadata.md b/docs/operate/cluster-metadata.md
index 8474dd8..781578e 100644
--- a/docs/operate/cluster-metadata.md
+++ b/docs/operate/cluster-metadata.md
@@ -7,7 +7,6 @@ This is the operator's single pane for "is the OAP backend
wired correctly?". It
- **Live health** of the two OAP ports.
- **Required-module state** for the four admin selectors.
- **Cluster member discovery** (OAP nodes behind the configured URL).
-- A planned strip for upcoming metadata views (per-node module activity,
storage health, receiver activity, effective config, TTL grid).
The triage flow during a banner-heavy incident lives here. The full check
sequence is documented in [Compatibility → Cluster Status Check
Sequence](../compatibility/cluster-status.md); this page focuses on what the
operator sees and does.
@@ -31,13 +30,6 @@ The triage flow during a banner-heavy incident lives here.
The full check sequen
│ oap-1.example.com 12800 receiver 2s ago │
│ oap-2.example.com 12800 receiver 1s ago │
│ oap-3.example.com 12800 receiver 3s ago │
-├─────────────────────────────────────────────────────────────────┤
-│ Coming soon (Phase 6 / 7): │
-│ • Per-node module activity matrix │
-│ • Storage backend health (BanyanDB / ES / JDBC) │
-│ • Receiver activity (gRPC / HTTP / Kafka / OTLP) │
-│ • Effective-configuration tree (two-node diff) │
-│ • TTL & retention grid │
└─────────────────────────────────────────────────────────────────┘
```
diff --git a/packages/api-client/src/dashboard.ts
b/packages/api-client/src/dashboard.ts
index 40fa911..214490b 100644
--- a/packages/api-client/src/dashboard.ts
+++ b/packages/api-client/src/dashboard.ts
@@ -26,7 +26,9 @@
* Defaults per layer are seeded from `apps/bff/src/dashboard/defaults.ts`
* — those defaults are lifted from the equivalent booster-ui templates
* so the metric coverage matches what operators expect on day one.
- * Phase 7 admin lets operators edit + persist their own widget set.
+ * Operators edit + persist their own widget set via the Dashboard
+ * setup admin pages, which write the override to OAP through the
+ * UI-template sync surface.
*/
/**
