wu-sheng opened a new pull request, #21: URL: https://github.com/apache/skywalking-horizon-ui/pull/21
## Summary - **Local dev env vars.** Vite + BFF now coordinate via `BFF_PORT` / `UI_DEV_PORT` (defaults 8081 / 9091) so a second Horizon can run side-by-side with the legacy booster-ui (8080) or with another dev env. `horizon.local.yaml` also accepts `OAP_QUERY_URL` / `OAP_ADMIN_URL` / `OAP_ZIPKIN_URL` / `OAP_TIMEOUT_MS` overrides, collapsing the per-target config files (`horizon.remote.yaml`, `horizon.unreachable.yaml`) into one canonical no-auth config that flexes via env. SKILL.md gains an "Environment variables (the dev contract)" reference table. - **Zipkin span detail = floating overlay.** The Lens-style detail panel (`LayerZipkinTracesView` + `ZipkinTracePopout`) floats over the right edge of the waterfall as `min(640px, 60%)`-wide instead of compressing it to a fixed 320px rail. Long tag values render on one line without truncating bars. Click-outside or Escape dismisses; in the popout, Escape unwinds one layer at a time (span → popout). - **Selection-mode height alignment.** The trace-detail card and the rail were independently sized (`align-items: start` + different max-heights), so the right card collapsed to content while the left rail extended down the viewport. Detail card now mirrors the rail's sticky / viewport-anchored height and the grid uses `align-items: stretch`. - **Popout listener leak.** Module-scope `addEventListener` calls in `ZipkinTracePopout` migrated to `onMounted` / `onBeforeUnmount`. - **Logs list truncation fix.** Rows without a `traceId` collapsed the 6-column grid one slot leftward, sizing the 1fr content cell to the 60px trace slot and ellipsing the preview at ~2 characters (`[2…`). The trace-link slot is now always rendered. ## Test plan - [ ] Default ports: `pnpm --filter @skywalking-horizon-ui/bff run dev` (no env) → BFF on :8081, Vite on :9091, login at `admin / admin`. - [ ] Parallel env: export `BFF_PORT=10081 UI_DEV_PORT=10091` on **both** processes → second env serves on :10091, talks to BFF on :10081. - [ ] Remote OAP: `OAP_QUERY_URL=http://<host>:12800 OAP_ADMIN_URL=http://<host>:17128 HORIZON_CONFIG=…/horizon.local.yaml` → `/api/oap/config` shows the override; admin readiness loop doesn't 404. - [ ] Zipkin trace, pick a span → detail panel floats at the right edge, doesn't compress the waterfall; long tag values readable. - [ ] With span pinned: click empty waterfall space → panel dismisses. Click another span → panel swaps. Press Escape → panel dismisses. - [ ] Popout (Expand): Escape clears the pinned span first; second Escape closes the popout. - [ ] Selection mode (rail + detail): list and detail cards visually align at the same height. - [ ] Logs list: rows without a `traceId` show the full content preview (clipped by row width, not by column collapse). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
