wu-sheng opened a new pull request, #29:
URL: https://github.com/apache/skywalking-graalvm-distro/pull/29

   ### Add a live-debugging e2e and fix the latent native-image bug it exposed
   
   Immigrates an e2e that verifies the distro's contract for the **DSL live 
debugger** (SWIP-13, `/dsl-debugging/*`) and **runtime-rule hot-update** 
(`/runtime/*`). Both need runtime Javassist codegen the closed-world native 
image can't do, so the admin-server (`:17128`) answers them with a structured 
**HTTP 501** that points users to the JVM distribution.
   
   **What it caught:** running the case against the native OAP showed those 
endpoints returning **404, not 501**. `UnsupportedAdminFeatureHandler` is a 
distro-only Armeria handler, so the build-time precompiler (which 
`oap-graalvm-server` depends on, hence cannot scan it) never registered its 
reflection metadata. Armeria builds annotated routes by reflection, so the 
routes were silently never created. The boot log even prints `Bind handler 
UnsupportedAdminFeatureHandler into http server 0.0.0.0:17128`, yet every 
request 404s. It had been dead since written — no prior e2e exercised port 
17128. Fixed by registering the handler in `reachability-metadata.json` with 
the same flags the precompiler emits for upstream admin handlers.
   
   - [x] Adds `test/e2e/cases/live-debugging/` (8 verify cases: 6 response-body 
assertions across both prefixes and all verbs + 2 HTTP-status-line checks) and 
the CI matrix entry.
   - [x] Fixes the 404 -> 501 regression via the reflection registration.
   - [x] Updated `changes/changes.md`.
   - [x] Verified locally end-to-end: native rebuild + infra-e2e run = **8/8 
pass** (404 before the fix).
   - [x] License headers valid: `license-eye header check` (0 invalid).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to