Copilot commented on code in PR #1147: URL: https://github.com/apache/skywalking-banyandb/pull/1147#discussion_r3337963528
########## pkg/query/logical/trace/trace_plan_distributed_test.go: ########## @@ -0,0 +1,79 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package trace + +import ( + "testing" + + "github.com/stretchr/testify/require" + + modelv1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/model/v1" + tracev1 "github.com/apache/skywalking-banyandb/api/proto/banyandb/trace/v1" + pbv1 "github.com/apache/skywalking-banyandb/pkg/pb/v1" +) + +func TestDistributedTraceResultIteratorPreservesTagOrderAndSpanAlignment(t *testing.T) { + iterator := &distributedTraceResultIterator{ + traces: []*tracev1.InternalTrace{ + { Review Comment: The new iterator behavior is supposed to null-fill missing per-span values to keep tag columns aligned, but this test only covers duplicates and does not cover the key scenario where a tag is present on some spans and absent on others. Adding a span that omits one projected tag (or introducing a tag only on the second span) would verify that the missing slot is filled with NullTagValue and that every tag’s Values length matches the span count. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
