wu-sheng opened a new pull request, #41:
URL: https://github.com/apache/skywalking-horizon-ui/pull/41

   ## What
   
   Two operator-visible fixes on the per-layer drill-down pages.
   
   ### 1. Scope aliases not applied in layer dashboard headers
   
   The sidebar nav already renders a layer's slot aliases (e.g. ActiveMQ → 
**Brokers** / **Destinations**, Virtual MQ → **Topics** / **MQ clusters**), but 
three spots in the layer pages still showed the raw scope words:
   
   - the **Instance** section header on the Instance page,
   - the **Endpoint** section header on the Endpoint page,
   - the **Service** column header in the service picker.
   
   These now resolve the same `layer.slots.*` aliases (with a fallback to the 
generic word when a layer defines none), so the content area matches the 
sidebar.
   
   ### 2. Instance/Endpoint page hangs on "Reading data…" when a service has no 
entities
   
   The Instance/Endpoint dashboard scopes gate the widget batch on a resolved 
entity (`useLayerDashboard` `enabled`). When the selected service reports 
**no** instances/endpoints — e.g. the demo's Virtual MQ service, which is alive 
(it has `mq_service_consume_cpm` traffic) but `findEndpoint` returns `[]` — no 
entity can ever be selected, so the query never fires, `dataIsFresh` never 
flips, and the reset-then-load overlay spins **"Reading data…" forever** while 
the picker correctly shows "none found".
   
   Fix: detect the terminal empty-entity state (`noEntityToChart`), suppress 
the overlay, and fall through to the widget grid so every widget renders in its 
normal **"no data"** state. The layout stays visible and ready for services 
that *do* report instances/endpoints. The overlay still covers genuine waits 
(list still loading, pin lookup in flight, service still resolving).
   
   ## Validation
   
   - Root cause confirmed against a live OAP (Apache demo): the Virtual MQ 
service reports consume traffic but `findEndpoint` returns `[]` over both 
60-min and 24-hour windows — genuinely no topics, not a query bug.
   - `vue-tsc --noEmit` clean; `license-eye header check` clean.
   
   ## Notes
   
   Backend contracts unchanged — UI-only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to