songzhendong commented on PR #13891: URL: https://github.com/apache/skywalking/pull/13891#issuecomment-4629769376
Root cause identified. Thanks for the detailed review — you were right about the pool expected mismatch.Before this fix, we had not run the official infra-e2e path (e2e run) locally. We were still unfamiliar with how SkyWalking e2e is wired in CI (e2e.yaml + -cases.yaml + expected/ + infra-e2e verifier), and overlooked using infra-e2e as the local validation gate. Instead, we used custom bash verify scripts (verify-mock-e2e.sh / verify-cluster-e2e.sh) that only check whether swctl metrics exec returns TIME_SERIES_VALUES with a non-null numeric value — they do not compare output against the expected/.yml templates. The earlier “mock 30/30” / “cluster 25/25” numbers came from those scripts, not from e2e run, so the label mismatch was missed locally but caught by CI and your analysis. Fix (e1dd30de) Added expected/metrics-has-value-label-poolname.yml (asserts pool_name label, same pattern as ActiveMQ). Repointed pool queries in airflow-cases.yaml (7) and airflow-cluster-cases.yaml (6; cluster still omits unstable pool_queued_slots). Verification after fix We ran full infra-e2e on Linux/WSL2 (same path as CI): mock 30/30, cluster 25/25 passed. We will use e2e run as the local gate going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
