wu-sheng commented on PR #13892:
URL: https://github.com/apache/skywalking/pull/13892#issuecomment-4631627059

   Thanks for the interest in SkyWalking and the kind words, @yogesh-tessl πŸ™
   
   One correction on the frontmatter change, though. These files live under 
`.claude/skills/`, so the schema that actually governs them is Claude Code's 
own [frontmatter 
reference](https://code.claude.com/docs/en/skills#frontmatter-reference):
   
   - `argument-hint` **is** a recognized top-level key there β€” it's what drives 
the `/generate-classes` autocomplete hint.
   - `metadata` is **not** in that reference, so Claude Code silently ignores 
it.
   
   So moving `argument-hint` under a `metadata:` block doesn't make it "proper" 
β€” it actually hides the hint from the only tool that consumes these files, and 
it makes this skill the lone outlier (our other six skills all use a top-level 
`argument-hint`). The "validation warning" you saw is from Tessl's schema, 
which differs from Claude Code's on this point.
   
   Same with the 81% β†’ 93% "skill score": that's a Tessl metric. Claude Code 
has no native skill score, so it's not something we can reason about or gate on 
from our side.
   
   The expanded "Use when…" description is a fair improvement and matches 
Claude Code's own "put the key use case first" guidance β€” happy to keep that 
part. Could you revert the `metadata:` move (restore the top-level 
`argument-hint`) and drop the repeated "verify exit code 0 / BUILD SUCCESS" 
lines? An agent running `mvn test` already sees the failure, so they add length 
without changing behavior. With those two tweaks it's an easy merge.
   
   Thanks again for taking the time to look. πŸ™‡
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to