hanahmily commented on PR #1161: URL: https://github.com/apache/skywalking-banyandb/pull/1161#issuecomment-4637469649
Thanks for the review — addressed all three in `e0cb1bb8`: 1. **`sub.go` Send defer / `replyWithErrType` nil metrics** — both now nil-guard `s.metrics`, matching the other recording sites (a server constructed without `PreRun()` has nil metrics). 2. **`helpers.go` `handleEOF` nil response / nil `writeEntity`** — `writeEntity` is nil when the stream closes (`Recv` → `io.EOF`), so the batch flush now reads `MessageId` safely and always sends a non-nil `SendResponse`. (`replyWithErrType` got the same guard since `handleEOF` calls it.) 3. **`batch.go` backwards comment** — renamed `isFirstSent` → `firstFrameSent` with a corrected comment (false until the first frame, which carries `sender_*`, is sent). Build, lint, and `go test ./banyand/queue/... ./api/data/...` are green; the batch-flush path is exercised by the `banyand/queue/test` integration suite. Also merged latest `main` (incl. #1160). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
