hanahmily opened a new pull request, #1171: URL: https://github.com/apache/skywalking-banyandb/pull/1171
## Summary - **Batch-write metric catalogs**: Add `totalBatchStarted`/`totalBatchFinished` and `totalMessageStarted`/`totalMessageFinished` counters + latency histogram to the queue sub path; fix started/finished symmetry so `started` ticks only immediately before `Rev()` (pre-Rev early returns produce no metric change). - **Group label population**: Wire `metadata.GetGroup()` into `bus.NewBatchMessageWithNodeAndGroup` in all four liaison/grpc handlers (measure, stream, trace, topn) so all queue pub/sub metrics carry a non-empty `group` label. - **collectDisk fix**: Change `return` → `continue` in the first `collectDisk` loop so a single failing disk path does not abort gauge updates for all healthy paths. - **FODC dashboard improvements**: Add topology panels (pod-to-pod flows table) that were accidentally dropped; add batch-write panels to the workload dashboard; add `grafana-fodc-nodes.json` and `grafana-fodc-workload.json` docs. - **E2E verification**: Add a kind-based e2e test (`test-fodc-dashboard-e2e.yml`) that verifies all FODC Grafana dashboard metrics are exported, non-empty, carry required label dimensions, and canonical OAP groups (`sw_metadata`, `sw_records`, `sw_metricsMinute`) have positive write traffic; add a dashboard-sync CI check. ## Test plan - [ ] `make lint` — passes clean (0 issues) - [ ] `go test ./banyand/queue/pub/... ./banyand/queue/sub/... ./banyand/observability/services/... ./banyand/liaison/grpc/... -count=1` — all pass - [ ] FODC e2e kind test (`test-fodc-dashboard-e2e.yml`) — passes after regression verification in GKE cluster - [ ] Dashboard sync check (`check-dashboard-sync.sh`) — all dashboard metrics covered by the three test lists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
