wu-sheng opened a new pull request, #136:
URL: https://github.com/apache/skywalking-nodejs/pull/136

   `CONTRIBUTING.md` (the guide the `[VOTE]` email links for building the 
release from source) was stale and actively broken:
   
   - Said **NodeJS 14** / `docker run … node:14` — but `node:14` can't build 
the project anymore (grpc-tools 1.13.x's `node-pre-gyp` needs **Node ≥18.17**; 
it's the exact `npm i` failure CI hit before the matrix bump).
   - Omitted **`git submodule update --init --recursive`** — `protocol/` is a 
git submodule, so a fresh-clone build dies with `Cannot find module 
'../proto/...'`.
   
   Updated to **Node 20** (the `engines.node` baseline; CI tests 20/22/24), 
added the submodule step, and documented `npm run lint` / `npm run test`. Also 
fixed `README.md`'s "NodeJS >= 14" → ">= 20".
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to